Adds AboutFiltering topic to the ActiveDirectory module #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steviecoaster
requested changes
Jan 8, 2020
Collaborator
steviecoaster
left a comment
There was a problem hiding this comment.
LGTM, minus one small nitpick.
vexx32
requested changes
Jan 12, 2020
PSKoans/Koans/Modules/ActiveDirectory/Introduction/AboutFiltering.Koans.ps1
Outdated
Show resolved
Hide resolved
PSKoans/Koans/Modules/ActiveDirectory/Introduction/AboutFiltering.Koans.ps1
Outdated
Show resolved
Hide resolved
PSKoans/Koans/Modules/ActiveDirectory/Introduction/AboutFiltering.Koans.ps1
Show resolved
Hide resolved
vexx32
requested changes
Jan 13, 2020
Owner
vexx32
left a comment
There was a problem hiding this comment.
Found a few more bits and pieces that we should probably take care of before we merge. 🙂
PSKoans/Koans/Modules/ActiveDirectory/Introduction/AboutFiltering.Koans.ps1
Outdated
Show resolved
Hide resolved
PSKoans/Koans/Modules/ActiveDirectory/Introduction/AboutFiltering.Koans.ps1
Outdated
Show resolved
Hide resolved
PSKoans/Koans/Modules/ActiveDirectory/Introduction/AboutFiltering.Koans.ps1
Outdated
Show resolved
Hide resolved
PSKoans/Koans/Modules/ActiveDirectory/Introduction/AboutFiltering.Koans.ps1
Outdated
Show resolved
Hide resolved
PSKoans/Koans/Modules/ActiveDirectory/Introduction/AboutFiltering.Koans.ps1
Outdated
Show resolved
Hide resolved
…ing.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <[email protected]>
…ing.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <[email protected]>
…ing.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <[email protected]>
…ing.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <[email protected]>
…ing.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <[email protected]>
vexx32
previously approved these changes
Jan 13, 2020
Owner
vexx32
left a comment
There was a problem hiding this comment.
Looks good to me!
I have one follow-up question that's more of a general concern with this module. Since it relies on external data, these koans are going to be more fragile to work with by nature. I'm not sure it makes sense at this point, but perhaps in future it may make more sense to Mock the AD cmdlets rather than operate with live data?
Contributor
Author
|
Yeah, I agree. Have to see which direction it goes in, we don't get all that many questions about things other than its complex filter parsing. |
vexx32
reviewed
Jan 13, 2020
PSKoans/Koans/Modules/ActiveDirectory/Introduction/AboutFiltering.Koans.ps1
Outdated
Show resolved
Hide resolved
…ing.Koans.ps1 Co-Authored-By: Joel Sallow (/u/ta11ow) <[email protected]>
vexx32
approved these changes
Jan 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Adds a module for ActiveDirectory with a short AboutFiltering topic.
Context
Attempts to cover frequently asked questions about filtering with the AD module.
Changes
Adds AboutFiltering.koans.ps1
Checklist