📝 AboutBinary - Fix incorrect value in number check #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the number check to match what is in the comment preceding it. Otherwise it is evaluating the wrong question and is confusing, plus the original number would be a repeat of a previous check.
vexx32
approved these changes
Nov 7, 2019
Owner
vexx32
left a comment
There was a problem hiding this comment.
Thanks for catching that! Surprised I missed that one! 😊💖🌸
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the number check to match what is in the comment preceding it. Otherwise it is evaluating the wrong question and is confusing, plus the original number would be a repeat of a previous check.
# PR Summary
Context
Changes
7to14to reflect the actual question and not be a repeat.Checklist