Skip to content

fix: settle aborted parallel steps before completing abortParallelWorkflow #2244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
pranaygp wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −5
Draft

fix: settle aborted parallel steps before completing abortParallelWorkflow #2244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions workbench/example/workflows/99_e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1829,18 +1829,23 @@ export async function abortParallelWorkflow() {
'use workflow';

const controller = new AbortController();
const parallelSteps = Promise.all([
longStep(controller.signal),
longStep(controller.signal),
longStep(controller.signal),
]);

const result = await Promise.race([
Promise.all([
longStep(controller.signal),
longStep(controller.signal),
longStep(controller.signal),
]),
parallelSteps,
sleep('3s').then(() => 'timeout' as const),
]);

if (result === 'timeout') {
controller.abort();
// Wait for the in-flight steps to observe the abort before completing the
// workflow. Returning immediately leaves the parallel branch dangling and
// can keep the run open until the steps hit their natural 30s completion.
await parallelSteps;
return { status: 'timed out' };
}

Expand Down
Loading