Closed
Conversation
Merged
Contributor
|
I'm not convinced that moving the host field back onto record was the right call:
|
43 tasks
Contributor
|
Just noting, this will probably be superseded by the work done in #295, which @michaelfairley is scheduled to do shortly. |
Contributor
|
Given that #308 was merged, do we want to close this? |
Member
Author
|
Yep! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix ended up having some behavior consequences, hence the separate PR from #269.
The end result here is that the splunk sink will look first for the
host_fieldconfiguration, then any explicitly set"host"field in the structured data, and then fall back the the built inhostfield on the record. It will also fall back in the case thathost_fieldis set but these is no value in that field.Does that sound sane to everyone? /cc @binarylogic
Something else we might want to do is a less case-sensitive lookup for the default
"host"field.