odb--daemon: implement get-parent and get-ancestor commands#2
Open
mjcheetham wants to merge 5 commits intovdye:hackweek/more-odb-over-ipcfrom
Open
odb--daemon: implement get-parent and get-ancestor commands#2mjcheetham wants to merge 5 commits intovdye:hackweek/more-odb-over-ipcfrom
get-parent and get-ancestor commands#2mjcheetham wants to merge 5 commits intovdye:hackweek/more-odb-over-ipcfrom
Conversation
Expose the static `get_parent` function so we can use it in the odb--daemon implementation of the `get-parent` IPC call. Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
0f60ce0 to
43c0c43
Compare
Implement a basic version of the get-parent command in the ODB daemon that will simply call the `get_parent` function that is being routed over the IPC channel with the same arguments. This will get us a simple working proof of concept. Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
Expose the static `get_nth_ancestor` function so we can use it in the odb--daemon implementation of the `get-nth-ancestor` IPC call. Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
Implement a basic version of the get-nth-ancestor command in the ODB daemon that will simply call the `get_nth_ancestor` function that is being routed over the IPC channel with the same arguments. This will get us a simple working proof of concept. Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
43c0c43 to
fb50118
Compare
Reduce the length of the IPC API `get-nth-ancestor` to be shorter, so that the request key is less than 15 characters + 1 null terminator. Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
get-parent commandget-parent and get-ancestor commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement basic versions of the
get-parentandget-ancestorcommands in the ODB daemon that will simply call theget_parentandget_nth_ancestorfunctions, respectively, that are being routed over the IPC channel with the same arguments.This will get us a simple working proof of concept.
Note the IPC name of the
get_nth_ancestorfunction isget-ancestorbecause we need to keep the name under 15 characters + 1 byte for a null terminator.