Skip to content

cpu: x64: conv: remove unnecessary work around#4700

Merged
yair-obodovsky merged 1 commit intomainfrom
yobodovs/remove-unnecessary-work-around
Feb 26, 2026
Merged

cpu: x64: conv: remove unnecessary work around#4700
yair-obodovsky merged 1 commit intomainfrom
yobodovs/remove-unnecessary-work-around

Conversation

@yair-obodovsky
Copy link
Copy Markdown
Contributor

Remove unnecessary flow that touches every page in the input buffer in conv layer.
Related to jira: https://jira.devtools.intel.com/browse/MFDNN-14582

@yair-obodovsky yair-obodovsky requested a review from a team as a code owner February 18, 2026 11:54
@github-actions github-actions Bot added the platform:cpu-x64 Intel64/AMD64 processors. Codeowner: @oneapi-src/onednn-cpu-x64 label Feb 18, 2026
@yair-obodovsky
Copy link
Copy Markdown
Contributor Author

make test
set test_scope=NIGHTLY

@vpirogov
Copy link
Copy Markdown
Contributor

vpirogov commented Feb 25, 2026

There's one more spot with similar workaround:

if (is_amx && inp_buffer) {
// Workaround: for some machines SEGFAULT possible on tile load
// if the page was not touched before it
for (dim_t i = 0; i < jcp.inp_buffer_size;
i += brgemm_convolution_bwd_utils::P4K)
inp_buffer[i] = 0;
}

I do not see anything in matmul, but it's worth double checking.

@yair-obodovsky yair-obodovsky force-pushed the yobodovs/remove-unnecessary-work-around branch from 827b783 to fe85b84 Compare February 26, 2026 09:43
@yair-obodovsky
Copy link
Copy Markdown
Contributor Author

There's one more spot with similar workaround:

if (is_amx && inp_buffer) {
// Workaround: for some machines SEGFAULT possible on tile load
// if the page was not touched before it
for (dim_t i = 0; i < jcp.inp_buffer_size;
i += brgemm_convolution_bwd_utils::P4K)
inp_buffer[i] = 0;
}

I do not see anything in matmul, but it's worth double checking.

Removed from conv_bwd. We didn’t find it anywhere else.

@yair-obodovsky yair-obodovsky merged commit e1833ed into main Feb 26, 2026
17 checks passed
@yair-obodovsky yair-obodovsky deleted the yobodovs/remove-unnecessary-work-around branch February 26, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform:cpu-x64 Intel64/AMD64 processors. Codeowner: @oneapi-src/onednn-cpu-x64

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants