Add timeout overrides

[abnegate]

Summary by CodeRabbit

• New Features

  • Added support for configuring connection and read/write timeouts when connecting to the message broker.

• Improvements

  • Enhanced reliability and flexibility of message broker connections with new timeout options.

[coderabbitai]

Walkthrough

The AMQP class constructor was updated to accept two new readonly float parameters for connection and read/write timeouts, both defaulting to 3.0 seconds. These values are now passed to the AMQPStreamConnection. Additional code simplifications include use of the nullsafe operator and minor adjustments to method catch blocks and nack calls.

Changes

File	Change Summary
src/Queue/Broker/AMQP.php	Added connectTimeout and readWriteTimeout parameters to constructor; passed to connection; simplified close method with nullsafe operator; adjusted nack call in consume; updated catch block in withChannel.

Poem

In the warren of code, two timeouts appear,
Ensuring connections are crystal clear.
With nullsafe hops and catches neat,
The AMQP queue won’t skip a beat.
Three seconds to wait, then off we go—
A rabbit’s work, quick and thorough! 🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0eccc55 and fe8d6dd.

📒 Files selected for processing (1)

• src/Queue/Broker/AMQP.php (5 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

src/Queue/Broker/AMQP.php (2)

src/Queue/Consumer.php (1)

• close (27-27)

src/Queue/Broker/Redis.php (1)

• close (92-95)

🔇 Additional comments (5)

src/Queue/Broker/AMQP.php (5)

45-46: LGTM! Well-designed timeout parameter addition.

The new timeout parameters are well-implemented with sensible defaults (3.0 seconds) and follow PHP 8+ readonly property best practices. The placement at the end of the constructor maintains backward compatibility.

---

187-196: LGTM! Proper timeout parameter usage.

The timeout parameters are correctly passed to the AMQPStreamConnection constructor using named parameters, which improves code readability and maintainability.

---

134-134: LGTM! Good use of nullsafe operator.

The nullsafe operator (?->) provides a cleaner and more concise way to handle the conditional closing of the connection, eliminating the need for explicit null checks.

---

213-213: LGTM! Good cleanup of unused variable.

Removing the unused variable binding in the catch block is a good cleanup that improves code clarity without changing functionality.

---

99-99:

Details

❓ Verification inconclusive

Verify the behavioral change in nack() call.

The change from nack(requeue: false) to nack() modifies the default behavior. Please ensure this change is intentional and aligns with the expected message handling strategy.

---

🏁 Script executed:

#!/bin/bash
# Description: Check the default behavior of nack() method in php-amqplib
# Expected: Determine if nack() defaults to requeue: true or false

# Search for nack method definition and its default parameters
rg -A 10 "function nack" --type php

Length of output: 37

---

Manual Verification Required: Confirm nack() Default Requeue Behavior

• Location: src/Queue/Broker/AMQP.php (line 99)
• Change: from nack(requeue: false) to nack()
• We were unable to locate the upstream nack() method signature in php-amqplib to confirm whether it defaults to requeue = true or false.

Please verify that calling nack() without parameters aligns with your intended message handling strategy (i.e., whether messages should be requeued by default).

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.