Conversation
christyjacob4
requested changes
Aug 1, 2023
Contributor
christyjacob4
left a comment
There was a problem hiding this comment.
Looks good. Just some minor comments 😄
| WORKDIR /app | ||
| RUN git clone https://github.com/PineappleIOnic/mockoon.git . | ||
| RUN apk add --no-cache git | ||
| RUN git clone https://github.com/PineappleIOnic/mockoon.git |
There was a problem hiding this comment.
Is this added only for testing or will it also be used in prod? Do we want to use the forked repo or the actual one?
Contributor
Author
There was a problem hiding this comment.
Mockoon currently doesn't support range headers, I have a PR in the works to bring this feature over to their repo but currently I don't have the time to write tests for them so for now we are using my fork and will switch once I have more time to finish their tests and merge it into their repo
abnegate
reviewed
Aug 2, 2023
Co-authored-by: Jake Barnby <jakeb994@gmail.com>
Co-authored-by: Jake Barnby <jakeb994@gmail.com>
Co-authored-by: Jake Barnby <jakeb994@gmail.com>
christyjacob4
approved these changes
Aug 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sizeandversionto reports to allow more data for frontend