Conversation
eldadfux
requested changes
Sep 27, 2022
Member
eldadfux
left a comment
There was a problem hiding this comment.
A few suggestions:
- I would add all adapters under an
Adaptersfolder - All categories of adapters could still be at this path fore example:
src/Utopia/Messaging/Adapters/Email/Mailgun.php - With the new directory structure, specific abstract don't need a postfix. For example:
EmailAdapter.phpcan just beEmail.php Messagescould be an independent directory alongsideAdaptersso each entity is independent. No need for aMessagepostfix we can leverage namespaces for that with the new dir structure.- We should prefer shorter naming conventions when possible.
sendMessage()can be justsend()
eldadfux
requested changes
Sep 28, 2022
Member
eldadfux
left a comment
There was a problem hiding this comment.
Great work Jake! Left a few comments
|
|
||
| public function getMaxMessagesPerRequest(): int | ||
| { | ||
| return PHP_INT_MAX; |
Member
There was a problem hiding this comment.
We will probably hit HTTP request size limit before that.
Member
Author
There was a problem hiding this comment.
In that case the exception will propagate to the caller, the service has no limit, unless we want to apply an arbitrary one ourselves instead?
Member
There was a problem hiding this comment.
Not sure what might be the best approach, but we would need to take payload size to consideration at some point, either here or in Appwrite itself.
eldadfux
approved these changes
Sep 29, 2022
eldadfux
approved these changes
Sep 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adapterclass