feat: expose start and completion timestamps for task scan phases#1131
Open
diksha78dev wants to merge 1 commit into
Open
feat: expose start and completion timestamps for task scan phases#1131diksha78dev wants to merge 1 commit into
diksha78dev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves #802 by persisting granular
started_atandcompleted_attimestamps for each scan phase, and exposing them in theget_task_statuspayload.Changes Include:
phase_timestamps_jsonto thetaskstable schema.queuedtimestamp upon task creation._broadcast_phaseto use SQLite's atomicjson_setto safely mark the completion of the prior phase and the start of the new phase.get_task_statusto parse and includephase_timestampsin the detail payload.test_broadcast_phase_persists_to_dbassertions to handle the expanded JSON timestamp persistence logic.Related Issues
Closes #802
Type of Change
How Has This Been Tested?
test_broadcast_phase_persists_to_dbto assert that correct SQLitejson_setcommands are generated.test_scan_phase_included_in_status_responseto verify thatphase_timestampsdict is correctly evaluated and serialized in the task status response.Checklist