Skip to content

feat: expose notification retry backoff configuration in admin diagnostics#1129

Merged
utksh1 merged 1 commit into
utksh1:mainfrom
diksha78dev:fix/issue-801
Jun 20, 2026
Merged

feat: expose notification retry backoff configuration in admin diagnostics#1129
utksh1 merged 1 commit into
utksh1:mainfrom
diksha78dev:fix/issue-801

Conversation

@diksha78dev

Copy link
Copy Markdown
Contributor

Description

This PR provides operators with a structured way to inspect the active notification retry policy and delivery backoff settings by exposing a new admin diagnostics endpoint.

Changes included:

  • Added NotificationDiagnosticsResponse schema to represent the configuration contract.
  • Implemented get_delivery_configuration() helper in notification_service.py.
  • Exposed GET /api/v1/admin/diagnostics/notifications route protected by existing admin verification and rate limiting.
  • Added integration tests to ensure the endpoint contract is maintained and authentication works as expected.

Related Issues

Fixes #801

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

I wrote a new integration test (test_admin_diagnostics_notifications) and verified the behavior by running pytest testing/backend/integration/test_notification_routes.py.

The test verifies:

  • Unauthenticated access returns HTTP 401.
  • Authenticated access using a mocked admin_api_key returns HTTP 200.
  • The returned JSON payload strictly adheres to the NotificationDiagnosticsResponse contract, containing the correct keys and data types.

Checklist

  • My code follows the code style of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.

@utksh1 utksh1 added level:intermediate 35 pts difficulty label for moderate contributor PRs type:feature Feature work category bonus label area:backend Backend API, database, or service work labels Jun 20, 2026

@utksh1 utksh1 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Focused change with green checks; approving.

@utksh1 utksh1 merged commit 9a23008 into utksh1:main Jun 20, 2026
19 checks passed
@utksh1 utksh1 added the gssoc:approved Admin validation: approved for GSSoC scoring label Jun 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:backend Backend API, database, or service work gssoc:approved Admin validation: approved for GSSoC scoring level:intermediate 35 pts difficulty label for moderate contributor PRs type:feature Feature work category bonus label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TASK] Expose notification retry backoff configuration in admin diagnostics

2 participants