Skip to content

Fix: Resolve search filter controls overlap on findings page (#901) #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sahare-mayur-0071 wants to merge 2 commits into
base: main
Choose a base branch
from
+22 −12
Open

Fix: Resolve search filter controls overlap on findings page (#901) #1098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb0b655
Fix: resolve search filter controls overlap on findings page (#901)
sahare-mayur-0071 Jun 19, 2026
23c495e
Fix: add frontend-checks roll-up job for branch protection
sahare-mayur-0071 Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ jobs:
if: steps.run_benchmarks.outcome == 'failure'
run: |
echo "::warning::Performance benchmark thresholds exceeded or benchmarks failed to run. Check the job logs for details."
frontend-checks:
frontend-checks-matrix:
needs: [detect-changes, formatting-hygiene]
if: |
always() &&
Expand Down Expand Up @@ -302,3 +302,13 @@ jobs:
run: npm run test
- name: Build frontend
run: npm run build

frontend-checks:
needs: [frontend-checks-matrix]
runs-on: ubuntu-latest
if: |
always() &&
(needs.frontend-checks-matrix.result == 'success' || needs.frontend-checks-matrix.result == 'skipped')
steps:
- name: Frontend checks completed
run: echo "frontend-checks completed"
22 changes: 11 additions & 11 deletions frontend/src/pages/Findings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,9 +598,9 @@ export default function Findings() {
</div>
</div>

<div className="grid gap-4 xl:grid-cols-[minmax(0,1fr)_auto] xl:items-end">
<div className="grid gap-4 sm:grid-cols-2 lg:grid-cols-3 xl:grid-cols-4 2xl:grid-cols-8">
<div className="space-y-2">
<div className="flex flex-col gap-6">
<div className="grid gap-4 sm:grid-cols-2 lg:grid-cols-3 xl:grid-cols-4">
<div className="space-y-2 min-w-0">
<label className={filterLabelClass}>Target</label>
<select
value={filterTarget}
Expand All @@ -614,7 +614,7 @@ export default function Findings() {
</select>
</div>

<div className="space-y-2">
<div className="space-y-2 min-w-0">
<label className={filterLabelClass}>Scanner / Tool</label>
<select
value={filterScanner}
Expand All @@ -628,7 +628,7 @@ export default function Findings() {
</select>
</div>

<div className="space-y-2">
<div className="space-y-2 min-w-0">
<label className={filterLabelClass}>Asset</label>
<select
value={filterAsset}
Expand All @@ -642,7 +642,7 @@ export default function Findings() {
</select>
</div>

<div className="space-y-2">
<div className="space-y-2 min-w-0">
<label className={filterLabelClass}>Finding Kind</label>
<select
value={filterKind}
Expand All @@ -656,7 +656,7 @@ export default function Findings() {
</select>
</div>

<div className="space-y-2">
<div className="space-y-2 min-w-0">
<label className={filterLabelClass}>Analyst State</label>
<select
value={filterAnalystStatus}
Expand All @@ -670,7 +670,7 @@ export default function Findings() {
</select>
</div>

<div className="space-y-2">
<div className="space-y-2 min-w-0">
<label className={filterLabelClass}>Sort By</label>
<select
value={sortMode}
Expand All @@ -685,7 +685,7 @@ export default function Findings() {
</select>
</div>

<div className="space-y-2">
<div className="space-y-2 min-w-0">
<label className={filterLabelClass}>From Date</label>
<input
type="date"
Expand All @@ -695,7 +695,7 @@ export default function Findings() {
/>
</div>

<div className="space-y-2">
<div className="space-y-2 min-w-0">
<label className={filterLabelClass}>To Date</label>
<input
type="date"
Expand All @@ -706,7 +706,7 @@ export default function Findings() {
</div>
</div>

<div className="flex flex-wrap items-center gap-2">
<div className="flex flex-wrap items-center gap-2 lg:justify-end border-t border-silver-bright/10 pt-4">
<label className="inline-flex h-11 items-center gap-3 border border-silver-bright/10 bg-charcoal-dark px-4 text-[10px] font-black uppercase tracking-[0.18em] text-silver/75">
<input
type="checkbox"
Expand Down
Loading