test : added unit tests for routes JSON deserialization helpers#1079
Open
tmdeveloper007 wants to merge 1 commit into
Open
test : added unit tests for routes JSON deserialization helpers#1079tmdeveloper007 wants to merge 1 commit into
tmdeveloper007 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1065.
Summary of What Has Been Done:
Added testing/backend/unit/test_routes_json_helpers.py covering the three pure helper functions exported by backend.secuscan.routes_json_helpers. The module was extracted from routes.py in a prior merge; these tests directly import and exercise the real production functions. 14 tests, all passing.
Changes Made:
Impact it Made:
Zero test coverage for the routes JSON deserialization helpers. These functions run on every finding and asset-service row returned from the database; untested, a regression in the JSON parsing or renaming logic could silently corrupt or drop finding data in the API responses.
Note: This task is being handled by tmdeveloper007 — please assign to that account when picking it up.