Skip to content

Order by Raw bindings#134

Open
hashstudio wants to merge 1 commit intousmanhalalit:masterfrom
hashstudio:master
Open

Order by Raw bindings#134
hashstudio wants to merge 1 commit intousmanhalalit:masterfrom
hashstudio:master

Conversation

@hashstudio
Copy link

For the following use:

$query->orderBy(QB::raw('my_table.state = ?', ['success']));

@cdvrooman
Copy link

Shouldn't the $orderBindings and $bindings variables be initialized as array() instead of [] to maintain compatibility with PHP 5.3?

@TCB13
Copy link

TCB13 commented Oct 17, 2017

@hashstudio please fix the compatibility issue @cdvrooman noticed and add some unit tests. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants