Add button role to improve accessibility in app/settings #4114 #1580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hey @onyeepeace, @rjmackay It looks like this brave person signed our Contributor License Agreement. 👍 Always at your service, clabot |
renujain31
approved these changes
Oct 20, 2020
Contributor
renujain31
left a comment
There was a problem hiding this comment.
This looks good to me! Thanks @onyeepeace!
Contributor
|
@rowasc @Angamanga It would be great if you could also review it once! |
rowasc
approved these changes
Oct 20, 2020
Contributor
rowasc
left a comment
There was a problem hiding this comment.
@onyeepeace this is great. Could you add a testing checklist ? Basically the steps for QA to verify each change. Thanks . Once you do that, please tag @Obadha2 for testing.
@Obadha2 this is pre-approved but only once the checklist is added can we merge.
…in-app/settings-#4114
Contributor
|
QA'd, passes. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the following changes:
Testing checklist:
The buttons which are not button elements now act as buttons
I certify that I ran my checklist
Fixes ushahidi/platform#4114.
Ping @ushahidi/platform