First part of map-library migration #1534
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ushahidlee
approved these changes
Mar 3, 2025
Contributor
ushahidlee
left a comment
There was a problem hiding this comment.
Code looks neat and tidy. 👍
* Adjusting map in create-post view, first draft of map and location-search * Displaying pin in the right location when editing a post * Saving marker on click * Making map and location-picker pretty * Cleanup of location-select * Displaying map on post-details * Destroying map to avoid duplicate maps when switching between popup/desktop * Adding default-map if no basemap is set * Saving coordinates on click * Using correct basemap in post-edit * Using correct basemap in post-details
…ent-mzima into feature/openLayers
* First wms-layer added * Adding rainfall data * Small adjustment to make handling layers more flexible (in case we want to hide some layers) * Adding attributions to all layers * Removing repetition from wms-functions * Simplifying wms-function (copilot ftw!!)
…ent-mzima into feature/openLayers
* Showing map and geolocator in Settings-view * Updating coordinates on click * Changing base-layer when selecting a new one from the dropdown * Updating and saving zoom correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first part of moving over to OpenLayers, the map is not complete but...
Since filters and loading-posts are covered by another ticket, you might need to reload or go to data-view and back to map-view to get the pins to load.
Ticket: USH-1763