Skip to content

Conversation

@ushahidlee
Copy link
Contributor

Issues:

  • If the backend returns config too slowly, the deployment will be incorrectly "not found".
  • The not found page should block the loading of the onboarding and cookie modals.

Solution:

This PR changes the deployment not found guard logic to not pass until it has gotten a response from the backend for the initial config call. It also adds checks for the aforementioned modals to prevent them from displaying until it has a response from the backend and found a deployment.

Testing:

  • An unknown deployment will display the not found page, with no cookie or onboarding displayed.
  • The not found page doesnt display for deployments that exist.

@ushahidlee ushahidlee requested a review from Angamanga October 7, 2024 21:13
@linear
Copy link

linear bot commented Oct 7, 2024

@ushahidlee ushahidlee merged commit 36c194f into development Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants