Ush 1458 - Deployment not Found (with extra logic) #1274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Angamanga
approved these changes
Aug 23, 2024
Contributor
Angamanga
left a comment
There was a problem hiding this comment.
The addition makes sense + it works fine!
tuxpiper
pushed a commit
that referenced
this pull request
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The previous fix for the deployment not found issue (https://linear.app/ushahidi/issue/USH-1458/unhandled-deployment-error-client-stuck-in-loading-loop-on-subdomain) sometimes encountered a timing issue that prevented it from correctly assessing whether the deployment was not found, or just had not yet been loaded. This was due to the guard being executed faster than the backend could provide the data.
Solution:
I have added an observable to the session service that is updated only after config has been loaded or has failed to do so. The route guard that is checking to see if the deployment is found, will wait until this observable presents success or failure before running its checks.
Testing: