[Accessibility] Improve category expand/collapse button accessibility with aria-label #1173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… provide a clear and concise description of the button's purpose for screen reader users. - The aria-label text Expand or collapse category informs users that the button is used to toggle the visibility of category children. - This change ensures the button is more accessible and understandable for all users, including those who rely on screen readers.
added 3 commits
July 23, 2024 21:39
Ifycode
approved these changes
Aug 1, 2024
tuxpiper
pushed a commit
that referenced
this pull request
Aug 8, 2024
… with aria-label (#1173) * - Add an aria-label attribute to the <mzima-client-button> element to provide a clear and concise description of the button's purpose for screen reader users. - The aria-label text Expand or collapse category informs users that the button is used to toggle the visibility of category children. - This change ensures the button is more accessible and understandable for all users, including those who rely on screen readers. * Fixed the ariaLabel angular directive instead of using the normal html static aria label * Reverted the env file * Reverted the env file --------- Co-authored-by: ROSE <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Engineers Checklist
Description
Changes
aria-labelattribute to the<mzima-client-button>element with the value "Expand or collapse category"Screenshots
Before:
After:
Testing
aria-labelis read aloud correctly