Add other-option when configuring a survey #1128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ushahidlee
approved these changes
Jul 4, 2024
Contributor
ushahidlee
left a comment
There was a problem hiding this comment.
Nice and the code is good too. The PR mentions this should be available for "select" fields. Its not available, but the original ticket doesnt mention that so I'm approving it 👍
6 tasks
theobadha
pushed a commit
that referenced
this pull request
Jul 15, 2024
* Add other-option when configuring a survey * Removing other-option from dropdown * Removing forgotten mistake
theobadha
added a commit
that referenced
this pull request
Jul 15, 2024
* add steps to delete category - through bulk actions * update categories to match CI categories * add missing step * update tests for CI * update and rerun tests * update and rerun tests * rerun tests * separate delete child and parent category tests into separate functions * update child test deleted * rerun tests * change child category getting deleted * change child category getting deleted * adjust id to verify child category * rerun tests * rerun tests * rerun tests * rerun tests * rerun tests * add tests for deleting category from category details page * update test * update url verifying path * change parent category getting deleted * rerun tests * rerun tests * update child category verification * rerun tests * rerun tests * rerun tests * rerun tests * rerun tests * Add other-option when configuring a survey (#1128) * Add other-option when configuring a survey * Removing other-option from dropdown * Removing forgotten mistake * Ush 1190 - Meaningful error messages on mobile around offline posts being uploaded (#1152) * commit * Made some cheeky changes (#1155) * Fix: Adding of post to collection submit & checked state (#1133) Co-authored-by: Anna Iosif <[email protected]> * rerun tests * rerun tests * rerun tests * rerun tests * rerun tests * rerun tests * rerun tests * rerun tests * rerun tests * rerun tests * rerun tests * rerun tests * rerun tests * rerun tests --------- Co-authored-by: Anna Iosif <[email protected]> Co-authored-by: ushahidlee <[email protected]> Co-authored-by: Mary @Ifycode <[email protected]>
tuxpiper
pushed a commit
that referenced
this pull request
Aug 8, 2024
* Add other-option when configuring a survey * Removing other-option from dropdown * Removing forgotten mistake
tuxpiper
pushed a commit
that referenced
this pull request
Aug 8, 2024
* add steps to delete category - through bulk actions * update categories to match CI categories * add missing step * update tests for CI * update and rerun tests * update and rerun tests * rerun tests * separate delete child and parent category tests into separate functions * update child test deleted * rerun tests * change child category getting deleted * change child category getting deleted * adjust id to verify child category * rerun tests * rerun tests * rerun tests * rerun tests * rerun tests * add tests for deleting category from category details page * update test * update url verifying path * change parent category getting deleted * rerun tests * rerun tests * update child category verification * rerun tests * rerun tests * rerun tests * rerun tests * rerun tests * Add other-option when configuring a survey (#1128) * Add other-option when configuring a survey * Removing other-option from dropdown * Removing forgotten mistake * Ush 1190 - Meaningful error messages on mobile around offline posts being uploaded (#1152) * commit * Made some cheeky changes (#1155) * Fix: Adding of post to collection submit & checked state (#1133) Co-authored-by: Anna Iosif <[email protected]> * rerun tests * rerun tests * rerun tests * rerun tests * rerun tests * rerun tests * rerun tests * rerun tests * rerun tests * rerun tests * rerun tests * rerun tests * rerun tests * rerun tests --------- Co-authored-by: Anna Iosif <[email protected]> Co-authored-by: ushahidlee <[email protected]> Co-authored-by: Mary @Ifycode <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding configuration-option for "Other" in the survey-fields radio, checkboxes and select.
To test:
In survey-settings, add a new field for Radio and Checkboxes, in all those fields, test the following:
The option is removed
The "Add other" button is visible again