fix(cli): avoid shell for GitHub auth token#2920
Merged
fahreddinozcan merged 2 commits intoJul 17, 2026
Merged
Conversation
Record why `gh auth token` must stay shell-free so the .cmd/.bat shim gap is not "fixed" by re-adding `shell`, which would restore the cmd.exe process that upstash#2918 is about. - reset mock implementations between tests so they stop leaking - assert listSkillsFromGitHub's result; the tests passed green without it - cover the GH_TOKEN fallback, which was previously untested - reword the changeset: execSync spawned a shell on every platform, and on Windows that shell was load-bearing rather than "unnecessary"
fahreddinozcan
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gh auth tokendirectly instead of routing it through a shellTesting
pnpm --filter ctx7 exec vitest run src/__tests__/github.test.tspnpm --filter ctx7 testpnpm --filter ctx7 typecheckpnpm --filter ctx7 lint:checkCloses #2918