60 make life easier for editorsreviewers#61
Merged
Conversation
amadulhaxxani
commented
Oct 21, 2025
- added action buttons (approve, reject, edit, and return to pool) inside the view page
adding the claimed actions button in view page
Workflow Actions Integration tests
adding test for onWorkflowActionCompleted and no response
subscription cleanup test
test for integration with action buttons
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the workflow review experience by adding action buttons (approve, reject, edit, return to pool) directly to the item view page, eliminating the need to navigate away to perform these actions.
Key Changes:
- Added a
showViewButtoninput toClaimedTaskActionsComponentto conditionally hide the "View" button when already on the view page - Integrated workflow action buttons into the full item page view for workflow items
- Added comprehensive unit tests covering the new functionality
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/themes/custom/lazy-theme.module.ts |
Imported MyDSpaceActionsModule to enable workflow actions in custom theme |
src/app/shared/mydspace-actions/claimed-task/claimed-task-actions.component.ts |
Added showViewButton input property to control view button visibility |
src/app/shared/mydspace-actions/claimed-task/claimed-task-actions.component.spec.ts |
Added tests for showViewButton functionality and action button integration |
src/app/shared/mydspace-actions/claimed-task/claimed-task-actions.component.html |
Made view button conditional based on showViewButton property |
src/app/item-page/item-page.module.ts |
Imported MyDSpaceActionsModule to enable workflow actions in item pages |
src/app/item-page/full/full-item-page.component.ts |
Added workflow item and claimed task data fetching logic with proper link resolution |
src/app/item-page/full/full-item-page.component.spec.ts |
Added comprehensive tests for workflow integration, action completion, and subscription cleanup |
src/app/item-page/full/full-item-page.component.html |
Added workflow action buttons at top and bottom of item view with conditional rendering |
removed extra lines
fixes suggested by copilot
removed extra line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.