Conversation
amadulhaxxani
commented
Oct 8, 2025
- Showing alternative message at Login screen when user is authenticated
- test for initializeTheAuthenticationState method
Created a guard so a user cannot navigate to login page if authenticated
Showing alternative message when user authenticated
removing the reverse auth guard approach
optimized the code
test for initializeTheAuthenticationState
rolling back the app routing file
roling back the core modules
lint fixes
There was a problem hiding this comment.
Pull Request Overview
This PR improves the user experience on the login page by displaying an alternative message and navigation options when a user is already authenticated, instead of showing the standard login form.
- Added logic to detect authenticated users and display an appropriate message with navigation options
- Enhanced the login page component with authentication state management
- Added new translation keys for the already-authenticated user interface
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/assets/i18n/en.json5 | Added English translations for already-authenticated user messages and reformatted existing arrays |
| src/assets/i18n/cs.json5 | Added Czech translations for already-authenticated user messages and reformatted existing arrays |
| src/app/login-page/login-page.component.ts | Added authentication state detection and user information retrieval logic |
| src/app/login-page/login-page.component.spec.ts | Added comprehensive tests for the authentication state initialization method |
| src/app/login-page/login-page.component.html | Added conditional rendering to show different content for authenticated vs non-authenticated users |
Comments suppressed due to low confidence (1)
src/assets/i18n/cs.json5:1
- The Czech translation file contains English text instead of Czech translations for the new authentication messages. These should be translated to Czech for proper internationalization.
{
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
removing the console.log statement
kosarko
requested changes
Oct 9, 2025
Member
kosarko
left a comment
There was a problem hiding this comment.
One question there, plus we should try to keep the amount of changes to a minimum - i.e. don't change formatting etc. when not necessary - it hides what the actual changes were
uncommenting changes
rolling back the cs.json5 changes
removing curation-task.task translation
rolling back the en.json5
removing curation-task trans
rolling back some unnecessary changes
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Comments suppressed due to low confidence (1)
src/assets/i18n/cs.json5:1
- The Czech translations are not localized - they contain English text. These strings should be translated to Czech to provide proper internationalization support.
{
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
preventing memory leak by properly unsubscribing from auth observables
chnaging the sub2 option for code consistency
…in-when-already-logged-in
removed two subs and keeping one subject instead for unsubscribing removing unused imports removing the takeUntil from 1st Sub as take(1) completes after one emission
using subs array for consistency
lint fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.