[bugfix] re-aligning subjfloat_functions with standardFunctionInfos when BFLOAT16 undefined#19
Open
nibrunieAtSi5 wants to merge 1 commit into
Open
[bugfix] re-aligning subjfloat_functions with standardFunctionInfos when BFLOAT16 undefined#19nibrunieAtSi5 wants to merge 1 commit into
nibrunieAtSi5 wants to merge 1 commit into
Conversation
…16 undefined standardFunctionInfos uses #ifdef BFLOAT16 to guard the addition of 2 entries from bf16 to/from f32 conversions, while subjfloat_functions array did not, this could lead to a misalignment depending on the build configuration.
aswaterman
approved these changes
Jun 26, 2025
Contributor
Author
|
@jerryz123, would you mind taking a look ? I believe a patch like this one is similar to fix testfloat when the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress
standardFunctionInfos uses #ifdef BFLOAT16 to guard the addition of 2 entries from bf16 to/from f32 conversions, while subjfloat_functions array did not, this could lead to a misalignment depending on the build configuration.
This could have been introduced in b205774, to fix another issue (or maybe I am misinterpreting the issue)
IMHO, It would be good to switch to a single array structure to avoid the possibility of creating discrepancies between the two (and also having to manually enforce ordering).