Plugin for controlling whether or not to fill in stacktraces#124
Plugin for controlling whether or not to fill in stacktraces#124
Conversation
This implements support for controlling whether or not `OutsideLifecycleException`s fill in their stacktraces. This is a potentially expensive operation that is often used just for signaling, so we can save a little perf here.
|
Is it possible to add more details about what the specific performance improvements are? Also +1 to Leland's comment about including example stacktraces to demonstrate the differences. |
|
Details beyond
? I’ll add an example, but bear in mind the point is that there is no trace, just the exception name and message. In a conventional “stacktrace”, the difference is that you effictively only get the first line here |
|
What is expensive? Just creating the stacktrace itself? Whatever it is, just mentioning it might be useful. |
|
Yes, |
|
Is it worth adding the same details to the javadoc? |
|
Beyond what's already there?
|
|
Yes, beyond what's already there. |
|
(talked and the javadoc is fine as-is) |
Resolves #117
This implements support for controlling whether or not
OutsideLifecycleExceptions fill in their stacktraces. This is a potentially expensive operation that is often used just for signaling, so we can save a little perf here.