Autodispose error prone checker

[bangarharshit]

AutoDispose error-prone checker can be really useful to catch lifecycle related errors in Activity/Fragment

Ribs has a version of the checker. Why not make it generic to any object with a lifecycle?

Few scenarios I can think of

1. All the subclasses of standard android component such as Activity/Fragment
2. All the subclasses of LifeCycleScopedProvider
3. When the LifeCycleScopedProvider is composed instead of inheriting the standard component such as Conductor

[ZacSweers]

Sure we could make an artifact. The only thing I'm hesitant about is that out internal implementation is a bit overbearing. Some synchronous streams should be allowed without binding. We could start with what we have and allow people to use it as an optional artifact. I would also prefer to have a lint artifact as well, so they'll show up in the IDE.

[bangarharshit]

Good point. UAST based lint checks can also be useful for Kotlin.

The case 1 and 2 (standard Android components and subclasses of LifeCycleScopedProvider) should be trivial to test.

The case 3 where lifecycle is composed is pretty complex since the actual class (controller in this case) is not aware of anything about LifeCycleScopedProvider and may need a custom annotation or a marker interface HasLifeCycle.

We can start with checks for case 1 and 2. The check 3 and the case where it should be allowed without binding is something that can be picked up in a followup commit.

[bangarharshit]

Another thought - some kind of whitelisting mechanism. The base cases such as activity/fragment/LifecycleScopeProvider can be hardcoded in the test.

We can use error-prone flags and any library can configure it. For ribs -

XepOpt:AutoDisposeLeakCheck=com.uber.rib.core.Router, com.uber.rib.core.Presenter, com.uber.rib.core.Interactor, com.uber.rib.core.Worker 

[ZacSweers]

Implementation is now in via #156, closing this is now pending on the wiki details

[bangarharshit]

Created a wiki in the PR - #162. Do you think it makes sense to create a new task for lint rule?

[ZacSweers]

Yeah new issue is fine

[ZacSweers]

This is done now!