README.mdの修正など#1
Merged
Merged
Conversation
Contributor
https://discord.com/channels/1196431244158849064/1251938021314400306/1252570307680800828 |
Contributor
|
今回は大丈夫ですが、よりアトミックなPRの方が望ましいです。つまり、複数の変更の一つの意味を持つ有機的な結合の方がいいです。README.md の修正なら README の修正、中国語の名残を日本語にすることならそれも一つのPRになるほうがいいかもしれません。 |
Contributor
|
LGTM! |
Member
Author
おっしゃる通りですね…。深夜に作業したということもあって、そこまで気が回っていませんでした。今後は気をつけます。 |
Member
Author
|
Discordでの議論に基づき、以下の文章は削除しました。
翻訳者のクレジットは今後の課題とします。 |
Merged
88 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
更新内容
index2cn.jsonという命名は中国語版ありきの名前なので、index2ja.jsonという日本語版用のファイルを作成しました{}-ja.yamlの形式で制作するものと規定しました分からなかったこと
README.mdには
と書いてありますが、翻訳者の名前を残す必要がある状況とは、どういう場面を想定していますか？