Skip to content

ignore zero area contours only when pyclipper cannot add them#51

Merged
anthrotype merged 6 commits intomasterfrom
self_intersecting_zero_area_paths
Dec 10, 2018
Merged

ignore zero area contours only when pyclipper cannot add them#51
anthrotype merged 6 commits intomasterfrom
self_intersecting_zero_area_paths

Conversation

@typemytype
Copy link
Owner

this solves zero area self intersection paths, but still ignores reall zero area paths like lines

#50
#48

this solves zero area self intersection paths, but still ignores reall zero area paths like lines

#50
#48
@typemytype typemytype requested a review from anthrotype December 5, 2018 09:12
@typemytype typemytype changed the title ignore zero area contours only when pyclipper cannot add them [WIP] ignore zero area contours only when pyclipper cannot add them Dec 5, 2018
@typemytype
Copy link
Owner Author

test fails cause difference and xor are NOT working properly (testing now)

@typemytype typemytype changed the title [WIP] ignore zero area contours only when pyclipper cannot add them ignore zero area contours only when pyclipper cannot add them Dec 5, 2018
@typemytype
Copy link
Owner Author

all fixed now
all test cases are working now
@anthrotype could you review and merge, this is maybe a change that can have a new release

@typemytype
Copy link
Owner Author

I dont now what adding a check for bounds does for performance... but since the last version of pyclipper this raises an error. Previous versions simple ignores empty clipper paths.

@typemytype
Copy link
Owner Author

a quick performance test: https://gist.github.com/typemytype/4ad64ad5d4f72b6662d74f418cd67c44

the timeit result are to close to each other (they both win once in a while) to speak of a performance dip.

@anthrotype
Copy link
Collaborator

Thanks @typemytype

@anthrotype anthrotype merged commit c993413 into master Dec 10, 2018
@anthrotype anthrotype deleted the self_intersecting_zero_area_paths branch December 10, 2018 12:54
anthrotype added a commit that referenced this pull request Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants