Merged
Conversation
61e5fe5 to
855b575
Compare
mdedetrich
commented
May 23, 2023
| addSbtPlugin("org.typelevel" % "sbt-typelevel" % "0.4.21") | ||
| addSbtPlugin("pl.project13.scala" % "sbt-jmh" % "0.4.4") | ||
| addSbtPlugin("org.scala-js" % "sbt-scalajs" % "1.10.1") | ||
| addSbtPlugin("org.scala-js" % "sbt-scalajs" % "1.13.1") |
Contributor
Author
There was a problem hiding this comment.
This is neccessary because the previous version of Scala.js was too outdated for Scala 3.3, i.e.
[error] org.scalajs.ir.IRVersionNotSupportedException: Failed to deserialize a file compiled with Scala.js 1.12 (supported up to: 1.8): /home/runner/work/jawn/jawn/parser/js/target/scala-3.3.0/test-classes/org/typelevel/jawn/parser/SyntaxCheck$JArray.sjsir
[error] You may need to upgrade the Scala.js sbt plugin to version 1.12 or later.
855b575 to
0d0de37
Compare
mdedetrich
commented
May 23, 2023
Contributor
Author
|
@eed3si9n @rossabaker @dwijnand PR is ready to review. Also #523 can be closed. |
0d0de37 to
d7129a1
Compare
Contributor
Author
|
@rossabaker @eed3si9n I have just rebased PR off main since #537 was merged |
Contributor
Author
|
All tests pass |
eed3si9n
approved these changes
May 31, 2023
Collaborator
eed3si9n
left a comment
There was a problem hiding this comment.
LGTM
Thanks @mdedetrich!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to Scala 3.3