Conversation
…wing users to specify ban start and ban end fields (and inheritely, is_permanent)
SputNikPlop
reviewed
Aug 9, 2023
Contributor
SputNikPlop
left a comment
There was a problem hiding this comment.
LGTM! Tested and works as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Problem/Feature
Fixes #195
Description of Changes:
twitch event trigger channel.bannow defaults to permabans--ban-startflag to specify thebanned_atfield--ban-endflag to specify theends_atfield and inherently theis_permanentfield--ban-endflag takes custom values, single numeric values for seconds (e.g. 600), or shorthand times (e.g. 10d4h12m55s)Checklist