Fix interdiff output when using --color=always#123
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #123 +/- ##
==========================================
+ Coverage 82.62% 82.71% +0.09%
==========================================
Files 5 5
Lines 4139 4155 +16
Branches 985 984 -1
==========================================
+ Hits 3420 3437 +17
+ Misses 719 718 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I think the extra allocations aren't necessary. What about making a variadic function called something like print_color() and having it handle the color escape codes? Or, since stdout is line-buffered when pointing to a terminal, you could print the color escape codes with an extra puts() before and after. Thoughts? |
|
You're right, that's much better, thanks! |
Assisted-by: Cursor
Fixed: #119 Assisted-by: Cursor
Suggestion from Sultan Alsawaf Assisted-by: Cursor
31664d0 to
126b622
Compare
|
@twaugh This comment was resolved but the extra code block wasn't removed: https://github.com/twaugh/patchutils/pull/123/files#r2350304053 Other than that, looks great! EDIT: Did it in PR #127 |
No description provided.