Skip to content

Comments

Drop .fossil-settings#34

Merged
psarna merged 1 commit intotursodatabase:mainfrom
penberg:no-fossil
Nov 16, 2022
Merged

Drop .fossil-settings#34
psarna merged 1 commit intotursodatabase:mainfrom
penberg:no-fossil

Conversation

@penberg
Copy link
Collaborator

@penberg penberg commented Oct 6, 2022

We don't use Fossil nor plan to, so drop the config.

We don't use Fossil nor plan to, so drop the config.
@penberg
Copy link
Collaborator Author

penberg commented Oct 6, 2022

@psarna What do you think about removing some of these things that we will never use? Will it make merging back from SQLite unnecessary hard?

@psarna
Copy link
Contributor

psarna commented Oct 6, 2022

Let's wait until the first backport of SQLite stuff (which we can try next week and start a regular schedule), and then decide

@penberg
Copy link
Collaborator Author

penberg commented Oct 6, 2022

@psarna Makes sense, will leave this pull request open until we make a decision.

@penberg
Copy link
Collaborator Author

penberg commented Oct 25, 2022

@psarna What do you want to do with this? Merge or close?

@psarna
Copy link
Contributor

psarna commented Oct 25, 2022

Perhaps left it in limbo for a while longer? Mostly because it would be interesting to recursively test libsql by testing fossil itself, because it uses SQLite as its blob store. And perhaps it would be easier with fossil settings in place

@psarna psarna merged commit 07155cc into tursodatabase:main Nov 16, 2022
@psarna
Copy link
Contributor

psarna commented Nov 16, 2022

rationale: those config files were last edited in 2017 according to git blame, and they can be restored very easily should anyone need them (which isn't going to happen)

@penberg penberg deleted the no-fossil branch November 16, 2022 14:32
@MarinPostma MarinPostma mentioned this pull request Oct 16, 2023
MarinPostma added a commit that referenced this pull request Oct 17, 2023
34: prevent interactive txn http r=penberg a=MarinPostma

depends on #33 
close #28


Co-authored-by: ad hoc <postma.marin@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants