Merged
Conversation
4f80864 to
ae3757b
Compare
Collaborator
|
@haaawk Wouldn't extending the protocol to only require one message for this use case be more maintainable? That is, make it possible to only send a |
Collaborator
Author
It would but this way we can give users improvement without forcing them to update their production dbs. We should work on extending the protocol to allow only a single message but in the meantime I have this to give users improvement straight away. |
b0e5a79 to
7a2e46c
Compare
LucioFranco
previously requested changes
Apr 16, 2024
Signed-off-by: Piotr Jastrzebski <piotr@chiselstrike.com>
7a2e46c to
3cc2303
Compare
Signed-off-by: Piotr Jastrzebski <piotr@chiselstrike.com>
3cc2303 to
3f51bc7
Compare
c998372 to
311accd
Compare
MarinPostma
approved these changes
Apr 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the client already has a session token we can try to prefetch next_frames during handshake.
For a replica in Sydney and primary in US it cuts the sync time from 400ms to 200ms.