"make distclean" didn't remove sqlite3session.h

[tjyang]

Not a developer but shouldn't "make distclean" remove all artifacts created by ./configure && make ?

• See following steps

./configure && make
make distclean

[me@ipa01 libsql]$ git status
On branch main
Your branch is up to date with 'origin/main'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        sqlite3session.h

nothing added to commit but untracked files present (use "git add" to track)
[me@ipa01 libsql]$

• One-liner fix to enable distclean to delete sqlite3session.h

[me@ipa01 libsql]$ git diff Makefile.in
diff --git a/Makefile.in b/Makefile.in
index cc4943f2c..617005561 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -1501,7 +1501,7 @@ clean:
        rm -f threadtest5

 distclean:     clean
-       rm -f config.h config.log config.status libtool Makefile sqlite3.pc \
+       rm -f config.h config.log config.status libtool Makefile sqlite3.pc sqlite3session.h \
                $(TESTPROGS)

 #
[me@ipa01 libsql]$

[psarna]

Yes, it should do a full cleanup - would you like to transform your fix into a pull request and post it? Then we can just go ahead and merge your contribution with your name properly listed as the author

[tjyang]

Yes, I will do that. Great one-liner fix for beginner like me ;-)

…

On Thu, Oct 6, 2022 at 9:50 AM Piotr Sarna ***@***.***> wrote: Yes, it should do a full cleanup - would you like to transform your fix into a pull request and post it? Then we can just go ahead and merge your contribution with your name properly listed as the author — Reply to this email directly, view it on GitHub <#30 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAC4ODSSQMXHB5LOVUUWEEDWB3RLTANCNFSM6AAAAAAQ6VITBI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

-- T.J. Yang

[tjyang]

Issue closed via #33