Skip to content

Fixes for Legion sub-build#2

Merged
trxcllnt merged 1 commit intotrxcllnt:fea/add-cmakefrom
jjwilke:fea/add-cmake
Jul 22, 2022
Merged

Fixes for Legion sub-build#2
trxcllnt merged 1 commit intotrxcllnt:fea/add-cmakefrom
jjwilke:fea/add-cmake

Conversation

@jjwilke
Copy link

@jjwilke jjwilke commented Jul 22, 2022

Fixes for two subtle issues around Legion. These issues only occur when re-configuring, not on the initial configure.

  • Legion_DIR gets set to -NOTFOUND on the initial configure, which was then triggering a REQUIRED on re-configure since it was only checking DEFINED rather than the Boolean-ness. The changes ensure that re-configuring does not trigger an error.
  • Legion_MAX_DIM and Legion_MAX_FIELDS ended up with different values after re-configure due to subtleties with set() and option().

@trxcllnt trxcllnt merged commit 2702a35 into trxcllnt:fea/add-cmake Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants