Enable using tblis_ROOT to find external tblis installations#1
Merged
trxcllnt merged 2 commits intotrxcllnt:fea/add-cmakefrom Jul 26, 2022
Merged
Enable using tblis_ROOT to find external tblis installations#1trxcllnt merged 2 commits intotrxcllnt:fea/add-cmakefrom
trxcllnt merged 2 commits intotrxcllnt:fea/add-cmakefrom
Conversation
jjwilke
commented
Jul 26, 2022
| # Makes `target_include_directories()` below work | ||
| file(MAKE_DIRECTORY "${tblis_BINARY_DIR}/include") | ||
|
|
||
| add_library(tblis::tblis ALIAS tblis) |
Author
There was a problem hiding this comment.
This should be inside the IF statement since the rapids_find_generate_module will generate the target if found.
trxcllnt
approved these changes
Jul 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There doesn't seem to be a way to point to an external tblis installation without the
rapids_find_generate_module. This adds the ability to give atblis_ROOT.