feat(config): optimize log for config without Blackhole account#6356
Merged
kuny0707 merged 3 commits intotronprotocol:release_v4.8.1from Aug 7, 2025
Merged
feat(config): optimize log for config without Blackhole account#6356kuny0707 merged 3 commits intotronprotocol:release_v4.8.1from
kuny0707 merged 3 commits intotronprotocol:release_v4.8.1from
Conversation
halibobo1205
approved these changes
Jun 24, 2025
kuny0707
approved these changes
Jun 24, 2025
barbatos2011
approved these changes
Jul 9, 2025
|
Hi, please resolve the conflicts |
bladehan1
approved these changes
Jul 9, 2025
13a276c to
d7715c7
Compare
CodeNinjaEvan
approved these changes
Jul 10, 2025
| assertsAddress.put(accountName, address); | ||
| } | ||
| if (assertsAddress.get(ACCOUNT_BLACKHOLE) == null) { | ||
| throw new TronError("Account[Blackhole] is not configured.", TronError.ErrCode.GENESIS_BLOCK_INIT); |
Contributor
There was a problem hiding this comment.
use ACCOUNT_BLACKHOLE instead of Blackhole?
Contributor
There was a problem hiding this comment.
Because this process occurs when the genesis block is being initialized
| AccountStore.setAccount(config); | ||
| Assert.fail(); | ||
| } catch (Throwable e) { | ||
| Assert.assertTrue(e instanceof TronError); |
Contributor
There was a problem hiding this comment.
add Assert.assertEquals("Account[Blackhole] is not configured.", e.getMessage());?
Contributor
There was a problem hiding this comment.
I think it is enough to judge the exception type, which is mainly functional testing rather than specific log information comparison.
lvs0075
approved these changes
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Optimize the log for configuration without Blackhole account. Fixes #6299
Why are these changes required?
This PR has been tested by:
Follow up
Extra details