feat(net) : optimize the isIdle method#5921
Merged
lvs007 merged 2 commits intotronprotocol:release_v4.7.6from Jul 23, 2024
Merged
feat(net) : optimize the isIdle method#5921lvs007 merged 2 commits intotronprotocol:release_v4.7.6from
lvs007 merged 2 commits intotronprotocol:release_v4.7.6from
Conversation
fyyhtx
approved these changes
Jul 19, 2024
CodeNinjaEvan
approved these changes
Jul 22, 2024
lvs007
approved these changes
Jul 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Optimize the isIdle method. refer to issue #5913
Why are these changes required?
During the block synchronization process, if the broadcast list has not been received, the synchronization may fail. The detailed process is as follows:
chain inventorymessage, setfetchFlagto true.startFetchSyncBlockmethod to fetch the block, and at this time,fetchFlagwill be set to false.advInvRequestis not empty at this time,peer.isIdle()returns false, so after this scheduling, the block is not obtained, butfetchFlagis set to false and cannot be set back, so the block cannot be obtained later.This PR has been tested by:
Follow up
Extra details