feat(metric): add interceptors to monitor gRPC using Prometheus#5884
Closed
halibobo1205 wants to merge 1 commit intotronprotocol:developfrom
Closed
feat(metric): add interceptors to monitor gRPC using Prometheus#5884halibobo1205 wants to merge 1 commit intotronprotocol:developfrom
halibobo1205 wants to merge 1 commit intotronprotocol:developfrom
Conversation
tomatoishealthy
approved these changes
Jun 25, 2024
xxo1shine
approved these changes
Jul 1, 2024
CodeNinjaEvan
approved these changes
Oct 9, 2024
Contributor
Author
|
close with #6097. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add interceptors to monitor gRPC services using Prometheus, inspired by https://github.com/grpc-ecosystem/java-grpc-prometheus
Why are these changes required?
1. Decoupled from the ApiAccessInterceptor.
2. Fix the response latency monitor of RPCs handled by the server, the
startCallis asynchronous, so the latency is not recorded correctly.This PR has been tested by:
Follow up
Extra details