fix(backup): make SR node with backup exit normally by kill -15#5868
Merged
lvs007 merged 1 commit intotronprotocol:developfrom Jul 1, 2024
Merged
Conversation
271a64c to
6550dfb
Compare
tomatoishealthy
approved these changes
Jun 21, 2024
xxo1shine
approved these changes
Jun 24, 2024
lvs007
approved these changes
Jul 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Make the thread pool close after the netty channel closes.
Why are these changes required?
Make the SR node with backup to be stopped normally by
kill -15.As shown below, the thread pool is closed first, and then the channel is closed. the thread can not exit because it is synchronized waiting for the channel close event, which prevents the thread pool from closing properly.

Finally, after 60 seconds of waiting, the thread pool is forced to close.

This PR has been tested by:
Follow up
Extra details