feat(all):make @PreDestroy work#5421
Merged
halibobo1205 merged 2 commits intotronprotocol:developfrom Aug 23, 2023
Merged
Conversation
a2c6f25 to
8bbd98c
Compare
lurais
reviewed
Aug 17, 2023
| super.destroy(); | ||
| super.doClose(); | ||
| logger.info("******** close end ********"); | ||
| FullNode.shutDownSign = true; |
Contributor
There was a problem hiding this comment.
Should the shutDownSign be assigned once the validate executor be closed? Is this reasonable to be here?
| channelFull.shutdown().awaitTermination(5, TimeUnit.SECONDS); | ||
| } | ||
| if (channelSolidity != null) { | ||
| channelSolidity.shutdown().awaitTermination(5, TimeUnit.SECONDS); |
Contributor
There was a problem hiding this comment.
What if the channelSolidity have not been shut down after 5 seconds?
Contributor
Author
There was a problem hiding this comment.
Waits for the channel to become terminated, giving up if the timeout is reached.
jwrct
reviewed
Aug 22, 2023
| } | ||
|
|
||
| @Override | ||
| public void destroy() { |
Contributor
There was a problem hiding this comment.
Shouldn't all the places where the destroy method is called be replaced, including all test code?
Contributor
Author
There was a problem hiding this comment.
destroy ->close -> doClose
tomatoishealthy
approved these changes
Aug 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #5420