feat(all): tune single Thread into SingleThreadExecutor#5410
Merged
halibobo1205 merged 5 commits intotronprotocol:developfrom Aug 15, 2023
Merged
feat(all): tune single Thread into SingleThreadExecutor#5410halibobo1205 merged 5 commits intotronprotocol:developfrom
halibobo1205 merged 5 commits intotronprotocol:developfrom
Conversation
a7968bf to
dbbb75d
Compare
xxo1shine
reviewed
Aug 14, 2023
| if (!pool.awaitTermination(60, java.util.concurrent.TimeUnit.SECONDS)) { | ||
| pool.shutdownNow(); // Cancel currently executing tasks | ||
| // Wait a while for tasks to respond to being cancelled | ||
| if (!pool.awaitTermination(60, java.util.concurrent.TimeUnit.SECONDS)) { |
Contributor
There was a problem hiding this comment.
Why there are two waits of 60s, will the 60s time be too long?
Contributor
Author
There was a problem hiding this comment.
60s is the maximum value to be waited until the pool stops, if it doesn't, the pool may have a problem executing the task and needs to be fixed.
Contributor
Author
There was a problem hiding this comment.
copy from java.util.concurrent.ExecutorService
| if (CommonParameter.getInstance().isJsonRpcFilterEnabled()) { | ||
| Thread filterProcessThread = new Thread(filterProcessLoop); | ||
| filterProcessThread.start(); | ||
| filterEs = ExecutorServiceManager.newSingleThreadExecutor(filterEsName, true); |
Contributor
There was a problem hiding this comment.
isDaemon original default value is false
| } | ||
| logger.info("DPoS task stopped."); | ||
| ExecutorServiceManager.shutdownAndAwaitTermination(produceExecutor, name); | ||
| logger.info("DPoS task shutdown complete"); |
Contributor
There was a problem hiding this comment.
Can the thread shutdown log be printed in the function shutdownAndAwaitTermination?
3e0a838 to
87c1b5d
Compare
tomatoishealthy
approved these changes
Aug 14, 2023
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5410 +/- ##
=============================================
+ Coverage 60.92% 60.94% +0.02%
- Complexity 9231 9242 +11
=============================================
Files 839 840 +1
Lines 50038 50059 +21
Branches 5576 5577 +1
=============================================
+ Hits 30484 30509 +25
+ Misses 17165 17152 -13
- Partials 2389 2398 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jwrct
approved these changes
Aug 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is #5362 's first PR. close #5409.