Add support for -tags

[whatupdave]

In my project (https://github.com/asm-products/readraptor) I'm using Goose for migrations and need to install a binary on Heroku. I'm using:

// +build heroku

package main

import _ "bitbucket.org/liamstask/goose/cmd/goose"

godep save fails to pick up the dependency. On Heroku, install runs with godep go install -tags heroku ./...

I think godep save -tags heroku ./... would fix the issue.

[kr]

I agree it makes sense for godep to have this.

For your particular case, is there a reason you can't put the import in a regular source file, without any build constraints?

[nf]

I have another case to support this: I have files that use // +build cgo to enable features on systems where C compilers are present, and // +build !cgo to stub out the functionality when it's not present. It feels like godep should at least use the same set of basic tags as the go command.

[nf]

Oh; it does. It was user error on my part.

[jnfeinstein]

Was this added or is there a workaround? I'm in need of this for Heroku as well.

[jnfeinstein]

I attempted to add this in #117.

[bgentry]

I also just ran into the same issue:

➜  git push heroku master                          
Initializing repository, done.
Counting objects: 907, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (824/824), done.
Writing objects: 100% (907/907), 306.85 KiB | 0 bytes/s, done.
Total 907 (delta 432), reused 161 (delta 30)

-----> Fetching custom git buildpack... done
-----> Go app detected
-----> Installing go1.3.1... done
-----> Running: godep go install -tags heroku ./...
api/install_goose.go:7:8: cannot find package "bitbucket.org/liamstask/goose/cmd/goose" in any of:
    /app/tmp/cache/go1.3.1/go/src/pkg/bitbucket.org/liamstask/goose/cmd/goose (from $GOROOT)
    /tmp/build_c5b1d26b-b1aa-4c3c-8390-fa99b9ea03ce/.heroku/g/src/github.com/myuser/myapp/Godeps/_workspace/src/bitbucket.org/liamstask/goose/cmd/goose (from $GOPATH)
    /tmp/build_c5b1d26b-b1aa-4c3c-8390-fa99b9ea03ce/.heroku/g/src/bitbucket.org/liamstask/goose/cmd/goose
godep: go exit status 1

 !     Push rejected, failed to compile Go app

Goose's recommended Heroku install method does seem like a bit of a hack, so I could understand if you don't want to support it.

[cpmech]

Hi, I'm just wondering if there are any updates on this? Cheers. D

[maxekman]

+1 for this. We would like to use it for including mocks only in the test run and not final build.

[phemmer]

For your particular case, is there a reason you can't put the import in a regular source file, without any build constraints?

You could do this, but in the case of goose, it pulls in a lot of deps that take a while to build. Thus when developing locally, go test takes quite some time to build things it doesn't need.

As another proposal, I think it would be nice for godep to automatically add a godep tag on all operations it performs (go list). This would allow creating dummy files with the godep tag so that additional packages (which aren't build or test deps) are vendored, and won't require passing the -tags flag all the time.

[freeformz]

atm as long as the imported package has files with build tags that include it on the local machine (a file with // +build heroku and a different file with // +build !heroku) both files will be included (assuming they are both committed to vcs). Ultimately we want to vendor everything regardless of tags so that code is buildable in multiple environments. See #271. I'm closing this for now in favor of that issue.