Skip to content

Fix dynaform preview that did not create new tab #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomolimo merged 1 commit into from
Nov 23, 2023
Merged

Fix dynaform preview that did not create new tab #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions js/cases.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,18 +28,21 @@ along with this plugin. If not, see <http://www.gnu.org/licenses/>.
glpi_pm = {
add_tab_panel: function (name, title, html){
//debugger ;
var loctabs = $('#tabspanel').next('div[id^=tabs]');
var loctabs = $('#tabspanel');
if( !loctabs[0].children[name] ) { // panel is not yet existing, create one
if( loctabs.find('a[href=\"#'+name+'\"]').length == 0 ) {
loctabs.find('ul').append( '<li><a href=\'#' + name + '\'>' + title + '</a></li>' );
if (loctabs.find('a[data-bs-target=\"#'+name+'\"]').length == 0 ) {
loctabs.append("<li class='nav-item ms-0'><a class='nav-link justify-content-between pe-1' href='#' data-bs-toggle='tab' title='" + title + "' data-bs-target='#" + name + "'>" + title + "</a></li>" );
}

loctabs.append( '<div id=\'' + name + '\'>' + html + '</div>');
loctabs.tabs('refresh'); // to show the panel
var select = loctabs.next('select');
select.append("<option value='" + (parseInt(select.children().last().val()) + 1) + "'>" + title + "</option >")
var tabcontentdiv = select.next('div');
tabcontentdiv.append("<div class='tab-pane fade' role='tabpanel' id='" + name + "'>" + html + "</div>");
$("a[data-bs-target='#" +name +"']").tab("show");
//tabcontentdiv.tabs('refresh'); // to show the panel
}
// activate it
var tabIndex = loctabs.find('a[href=\"#'+name+'\"]').parent().index();
loctabs.tabs( 'option', 'active', tabIndex) ; // to activate it
//var tabIndex = loctabs.find('a[href=\"#'+name+'\"]').parent().index();
// loctabs.tabs( 'option', 'active', tabIndex) ; // to activate it
},


Expand Down
2 changes: 1 addition & 1 deletion processmaker.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
<compatibility>9.5</compatibility>
</version>
<version>
<num>5.0.2</num>
<num>5.0.3</num>
<compatibility>10.0</compatibility>
</version>
</versions>
Expand Down
2 changes: 1 addition & 1 deletion setup.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
along with this plugin. If not, see <http://www.gnu.org/licenses/>.
--------------------------------------------------------------------------
*/
define('PROCESSMAKER_VERSION', '5.0.2');
define('PROCESSMAKER_VERSION', '5.0.3');

// Minimal GLPI version, inclusive
define('PLUGIN_PROCESSMAKER_MIN_GLPI', '10.0');
Expand Down