Updated SplitPane - Resize logic updated#406
Merged
wuweiweiwu merged 1 commit intotomkp:v2from Dec 13, 2019
Merged
Conversation
Author
|
@tomkp @wuweiweiwu @davvidbaker Can you please review my PR, I am using your react-split-pane v2.0.2 npm package in one of my projects and recently I saw there is some problem with the resizing of panes. I have raised the PR #406 as a fix for that, please can you review it and merge it to v2 branch so that I can import the package in my project. It would be of great help. |
Author
|
@tomkp @wuweiweiwu can you publish the branch change as the npm package? So, I can import that package as in the npm package v2.0.2 I still see the old change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to react-split-pane!
Before submitting a pull request, please complete the following checklist:
yarn run test) all passyarn run prettier).Here is a short checklist of additional things to keep in mind before submitting: