Replace getOwnPropertyDescriptor with hasOwnProperty#99
Merged
buschtoens merged 1 commit intotj:masterfrom Mar 29, 2014
toolmantim:replace-get-own-property-description-with-has-own-property
Merged
Replace getOwnPropertyDescriptor with hasOwnProperty#99buschtoens merged 1 commit intotj:masterfrom toolmantim:replace-get-own-property-description-with-has-own-property
buschtoens merged 1 commit intotj:masterfrom
toolmantim:replace-get-own-property-description-with-has-own-property
Conversation
|
If it works 👶 |
Collaborator
|
As noone has complained yet and this LGTM I'm gonna merge this. Thanks! :) |
buschtoens
added a commit
that referenced
this pull request
Mar 29, 2014
…iption-with-has-own-property Replace getOwnPropertyDescriptor with hasOwnProperty
Contributor
Author
|
@silvinci 👍 ta! |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the only thing preventing queryString from being IE8 compatible. And for our purposes we may as well use hasOwnProperty anyway, we're not using the getOwnPropertyDescriptor result.