Skip to content

Fix cargo clippy warnings, bugs and test issues #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JamyGolden merged 5 commits into from
Aug 18, 2025
Merged

Fix cargo clippy warnings, bugs and test issues #128

JamyGolden merged 5 commits into from
Aug 18, 2025

Conversation

@JamyGolden
Copy link
Member

@JamyGolden JamyGolden commented Aug 16, 2025 •
edited
Loading

  • Cargo clippy is not super important but nice to have. The changes make things easier to read
  • Fix test issues. base16-github changed to base16-github-light and tests have broken
  • Fix test data race bug where completions tmp directory could be removed when other tests are still running
  • Fix global config hooks bug where the hooks can be run out of list order
  • Update the contrib/completions. This is just for people who don't want to run tinty generate-completion {shell}, so doesn't affect the tinty binary

@JamyGolden JamyGolden requested a review from a team as a code owner August 16, 2025 12:19
@JamyGolden JamyGolden requested review from bezhermoso and removed request for a team August 16, 2025 12:19
@JamyGolden JamyGolden changed the title Fix cargo clippy warnings Fix cargo clippy warnings and test issues Aug 16, 2025
@JamyGolden JamyGolden force-pushed the jamy/chore/clippy branch 2 times, most recently from 34fef84 to 325cada Compare August 16, 2025 13:24
@JamyGolden JamyGolden changed the title Fix cargo clippy warnings and test issues Fix cargo clippy warnings, bugs and test issues Aug 16, 2025
@JamyGolden JamyGolden merged commit a22cb32 into main Aug 18, 2025
9 of 10 checks passed
@JamyGolden JamyGolden deleted the jamy/chore/clippy branch August 18, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bezhermoso bezhermoso bezhermoso approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JamyGolden @bezhermoso