Skip to content

Conversation

@mjpitz
Copy link
Contributor

@mjpitz mjpitz commented Jan 5, 2018

This should make it so that consumers can catch an Exception instead of any Error type.

@timols
Copy link
Owner

timols commented Jan 5, 2018

Easy. I thought you were going to create a new exception class. This works too :)

@timols timols merged commit 1b3dae4 into timols:master Jan 5, 2018
@islandsvinur
Copy link
Contributor

Got hit by an Error today (was still on 4.0.0), upgraded to 4.1.0, then got hit again by a generic RuntimeException. Glad it no longer kills my thread, but I would prefer the API to throw IOException as declared. Maybe wrap it here in UncheckedIOException, then unwrap and rethrow?

@timols I'll create an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants