refactor: rename nori-acp to nori-harness (slice H finale)#532
Open
CSRessel wants to merge 2 commits into
Open
refactor: rename nori-acp to nori-harness (slice H finale)#532CSRessel wants to merge 2 commits into
CSRessel wants to merge 2 commits into
Conversation
Adopt the Layer-1 name from docs/specs/crate-layering.md §3. With the low-level ACP hosting machinery extracted to nori-acp-host (slice G2) and session orchestration moved into the crate's runtime module (slice H2), this crate is the headless harness — transcript recording, session reducer, undo, worktrees, hooks, session runtime — not "the ACP crate". - directory acp/ → harness/, package nori-acp → nori-harness, lib nori_acp → nori_harness; all workspace deps and use-paths rewired - docs.md path references nori-rs/acp/ → nori-rs/harness/ - deliberately unchanged: the on-disk log prefix nori-acp (~/.nori/cli/log/nori-acp.*.log) — a runtime artifact external tooling greps for — and the nori-acp-host crate name - tui-pty-e2e tracing filter now names nori_harness and nori_acp_host explicitly; the old nori_acp directive had covered nori_acp_host only via string-prefix matching, and the exit-cleanup tests grep the acp-host "agent spawned (pid)" debug line Validation: full workspace suite green; tui-pty-e2e green (23 suites); elizacp close-the-loop TUI drive green; just fmt + just fix clean. Part of the crate-layering refactor (docs/specs/crate-layering.md).
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Also add nori-acp-host and nori-config to the CI test list — they were never added when extracted, so their suites (106 tests in acp-host) did not run in CI at all; only the workspace-local battery covered them. 🤖 Generated with [Nori](https://noriagentic.com) Co-Authored-By: Nori <contact@tilework.tech>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slice H finale of the crate-layering refactor (design doc). Stacked on #531 (slice H2, session runtime).
What
Renames the
nori-acpcrate tonori-harness— directoryacp/→harness/, package + lib name, all workspace deps, use-paths, and docs path references.Why now
Rename-on-adoption (design doc §5 convention): after G2 moved the low-level ACP hosting machinery out to
nori-acp-hostand H2 moved session orchestration in (theruntimemodule), what remains is the Layer-1 headless harness the design namesnori-harness— transcript recording, session reducer, undo, worktrees, hooks, session runtime. The old name described a responsibility the crate no longer owns exclusively.Deliberately unchanged
nori-acp(~/.nori/cli/log/nori-acp.YYYY-MM-DD.log) — a runtime artifact external tooling and debugging docs grep for.nori-acp-hostcrate (correctly named — it hosts ACP agents).One real find
The tui-pty-e2e tracing filter directive
nori_acp=debughad been coveringnori_acp_hosttargets only via tracing's string-prefix matching. After the rename, the exit-cleanup tests (which grep acp-host's "agent spawned (pid)" debug line) went red until the filter named both crates explicitly — it now does, so the coverage no longer depends on a name-prefix coincidence.Validation
tui-pty-e2egreen (23 suites, including the exit-cleanup suite above).just fmt,just fix -p nori-harnessclean.