refactor(tui,cli): import config from nori-config directly (slice H1)#530
Open
CSRessel wants to merge 1 commit into
Open
refactor(tui,cli): import config from nori-config directly (slice H1)#530CSRessel wants to merge 1 commit into
CSRessel wants to merge 1 commit into
Conversation
Rewire the Layer-2 frontends off nori-acp's config re-exports and onto the nori-config crate directly, per docs/specs/crate-layering.md §3: frontends take leaf crates directly; the harness crate is not a config pass-through. - tui/, cli/: `nori_acp::config::X` → `nori_config::X` (nori-config re-exports its surface flat at the crate root), plus the six top-level conveniences (ApprovalPolicy, FileManager, HistoryPersistence, NoriConfig, NoriConfigOverrides, find_nori_home) - nori-acp: public config surface sealed — the six `pub use config::*` re-exports deleted, `pub use nori_config as config` demoted to pub(crate) (53 internal uses unchanged); stale crate doc comment updated - tui/Cargo.toml: drop stale comment for the cargo feature removed in slice C Validation: full workspace suite green; tui-pty-e2e green (23 suites); elizacp close-the-loop TUI drive green; just fmt + just fix clean. Part of the crate-layering refactor (docs/specs/crate-layering.md).
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slice H1 of the crate-layering refactor (design doc). Stacked on #529 (slice G2, nori-acp-host extraction).
What
Rewires the Layer-2 frontends (
nori-tui,nori-clicrates) offnori-acp's config re-exports and onto thenori-configcrate directly, then sealsnori-acp's public config surface:nori_acp::config::X→nori_config::Xacross tui/ and cli/ (~200 references; nori-config re-exports its surface flat at the crate root), plus the six top-level conveniences (ApprovalPolicy,FileManager,HistoryPersistence,NoriConfig,NoriConfigOverrides,find_nori_home).nori-acp: the sixpub use config::*re-exports are deleted andpub use nori_config as configis demoted topub(crate)— config is no longer part of nori-acp's public API. Its 53 internalcrate::config::uses are unchanged.tui/Cargo.toml,cli/Cargo.tomlgain thenori-configworkspace dep; a stale comment referencing the cargo feature removed in slice C is dropped.Net −31 lines (224+/255−).
Why
Design doc §3: frontends take leaf crates directly; the harness crate is not a config pass-through. This makes dependency rule 2 ("nothing below Layer 2 knows a terminal exists, frontends reach leaves directly") mechanically visible in Cargo.toml instead of hidden behind re-exports, and shrinks the surface that must be considered when nori-acp becomes
nori-harness.Validation
cargo test --workspace --exclude tui-pty-e2e).cargo build --bin nori+cargo test -p tui-pty-e2egreen (23 suites).just fmt,just fix -p nori-tui/-p nori-cli/-p nori-acpclean.